TenchinZero/Lieb-Website
1
0
Fork 0
forked from Sarah/Lieb-Website
Code Pull requests Activity

removed defaults from FirstOrDefault to avoid reading everything with ToList

Browse source
This commit is contained in:
Sarah Faey 2022-12-05 11:55:21 +01:00
parent 24ad2b11e5
commit a4c29d8891
6 changed files with 50 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Lieb/Data/UserService.cs
View file

@ -66,8 +66,10 @@ namespace Lieb.Data
using var context = _contextFactory.CreateDbContext();
LiebUser user = context.LiebUsers
.Include(u => u.GuildWars2Accounts)
.ToList()
.FirstOrDefault(u => u.Id == userId, new LiebUser());
if(user == null) return new GuildWars2Account();
return user.GuildWars2Accounts.FirstOrDefault(g => g.GuildWars2AccountId == user.MainGW2Account, new GuildWars2Account());
}
@ -284,8 +286,9 @@ namespace Lieb.Data
using var context = _contextFactory.CreateDbContext();
LiebUser user = GetLiebUserGW2AccountOnly(userId);
Raid raid = context.Raids
.ToList()
.FirstOrDefault(r => r.RaidId == raidId, new Raid());
.FirstOrDefault(r => r.RaidId == raidId);
if(raid == null) return new List<GuildWars2Account>();
List<GuildWars2Account> accounts = GetAllUsableAccounts(user, raid.RaidType);
if(user.AlwaysSignUpWithMainAccount && accounts.Where(a => a.GuildWars2AccountId == user.MainGW2Account).Any())
@ -303,8 +306,9 @@ namespace Lieb.Data
using var context = _contextFactory.CreateDbContext();
LiebUser user = GetLiebUserGW2AccountOnly(userId);
Raid raid = context.Raids
.ToList()
.FirstOrDefault(r => r.RaidId == raidId, new Raid());
.FirstOrDefault(r => r.RaidId == raidId);
if(raid == null) return 0;
List<GuildWars2Account> usableAccounts = GetAllUsableAccounts(user, raid.RaidType);