From a438f1eeb4dac92770b5ec9de71eca7167ce71f4 Mon Sep 17 00:00:00 2001 From: Sarah Faey Date: Mon, 5 Dec 2022 12:36:46 +0100 Subject: [PATCH] the Discord SignUp Log message is no longer awaited --- Lieb/Data/RaidService.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Lieb/Data/RaidService.cs b/Lieb/Data/RaidService.cs index b3ad173..9753ce9 100644 --- a/Lieb/Data/RaidService.cs +++ b/Lieb/Data/RaidService.cs @@ -481,7 +481,7 @@ namespace Lieb.Data await context.RaidLogs.AddAsync(log); await context.SaveChangesAsync(); - await SendDiscordSignUpLogMessage(signUp, userName, signedUpBy); + _ = SendDiscordSignUpLogMessage(signUp, userName, signedUpBy); } public async Task SendDiscordSignUpLogMessage(RaidSignUp signUp, string userName, ulong signedUpBy = 0) @@ -509,16 +509,16 @@ namespace Lieb.Data } string message = $"{signedUpByUserName} signed up {userName} as {signUp.SignUpType.ToString()}"; - foreach(DiscordRaidMessage discordMessage in raid.DiscordRaidMessages) + HashSet guildIds = raid.DiscordRaidMessages.Select(m => m.DiscordGuildId).ToHashSet(); + foreach(ulong guildId in guildIds) { - DiscordSettings settings = _discordService.GetDiscordSettings(discordMessage.DiscordGuildId); + DiscordSettings settings = _discordService.GetDiscordSettings(guildId); if(settings.DiscordLogChannel > 0) { - await _discordService.SendChannelMessage(discordMessage.DiscordGuildId, settings.DiscordLogChannel, message, raid.Title); + await _discordService.SendChannelMessage(guildId, settings.DiscordLogChannel, message, raid.Title); } } } - await context.SaveChangesAsync(); } public async Task SendReminders()